Skip to content

Commit

Permalink
[render] update -> setPoints on line classes
Browse files Browse the repository at this point in the history
  • Loading branch information
alemuntoni committed Feb 8, 2025
1 parent e34462a commit 7819557
Show file tree
Hide file tree
Showing 23 changed files with 35 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ class DrawableLines : public vcl::DrawableObject

LineSettings& settings() { return mLines.settings(); }

void update(const std::vector<LinesVertex>& points)
void setPoints(const std::vector<LinesVertex>& points)
{
mLines.update(points);
mLines.setPoints(points);
}

// DrawableObject interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ class DrawablePolylines : public vcl::DrawableObject
return mPolylines.settings();
}

void update(const std::vector<LinesVertex>& points)
void setPoints(const std::vector<LinesVertex>& points)
{
mPoints = points;
mPolylines.update(points);
mPolylines.setPoints(points);
}

// DrawableObject interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class CPUGeneratedLines : public Lines

friend void swap(CPUGeneratedLines& a, CPUGeneratedLines& b) { a.swap(b); }

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

void draw(uint viewId) const;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class GPUGeneratedLines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class IndirectBasedLines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class InstancingBasedLines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class TextureBasedLines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class CPUGeneratedPolylines : public Lines

void swap(CPUGeneratedPolylines& other);

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

void draw(uint viewId) const;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class GPUGeneratedPolylines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class IndirectBasedPolylines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class InstancingBasedPolylines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class TextureBasedPolylines : public Lines

void draw(uint viewId) const;

void update(const std::vector<LinesVertex>& points);
void setPoints(const std::vector<LinesVertex>& points);

private:
void checkCaps() const
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ class MeshRenderBuffers
}
}
// wireframe index buffer
mWireframeBH.update(wireframe);
mWireframeBH.setPoints(wireframe);

// TODO: Should Be:
// const uint NUM_EDGES =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace vcl {

CPUGeneratedLines::CPUGeneratedLines(const std::vector<LinesVertex>& points)
{
update(points);
setPoints(points);
}

void CPUGeneratedLines::swap(CPUGeneratedLines& other)
Expand All @@ -41,7 +41,7 @@ void CPUGeneratedLines::swap(CPUGeneratedLines& other)
swap(mIndices, other.mIndices);
}

void CPUGeneratedLines::update(const std::vector<LinesVertex>& points)
void CPUGeneratedLines::setPoints(const std::vector<LinesVertex>& points)
{
if (points.size() > 1) {
// generate memory buffers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ GPUGeneratedLines::GPUGeneratedLines(const std::vector<LinesVertex>& points)
checkCaps();
assert(bgfx::isValid(mComputeVerticesPH));

update(points);
setPoints(points);
}

void GPUGeneratedLines::swap(GPUGeneratedLines& other)
Expand All @@ -54,7 +54,7 @@ void GPUGeneratedLines::draw(uint viewId) const
bgfx::submit(viewId, mLinesPH);
}

void GPUGeneratedLines::update(const std::vector<LinesVertex>& points)
void GPUGeneratedLines::setPoints(const std::vector<LinesVertex>& points)
{
if (points.size() > 1) {
allocateAndSetPointsBuffer(points);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ IndirectBasedLines::IndirectBasedLines()
IndirectBasedLines::IndirectBasedLines(const std::vector<LinesVertex>& points) :
IndirectBasedLines()
{
update(points);
setPoints(points);
}

void IndirectBasedLines::swap(IndirectBasedLines& other)
Expand Down Expand Up @@ -75,7 +75,7 @@ void IndirectBasedLines::draw(uint viewId) const
bgfx::submit(viewId, mLinesPH, mIndirect.handle(), 0);
}

void IndirectBasedLines::update(const std::vector<LinesVertex>& points)
void IndirectBasedLines::setPoints(const std::vector<LinesVertex>& points)
{
generateIndirectBuffer(points.size());
allocateAndSetPointsBuffer(points);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ InstancingBasedLines::InstancingBasedLines()
InstancingBasedLines::InstancingBasedLines(
const std::vector<LinesVertex>& points) : InstancingBasedLines()
{
update(points);
setPoints(points);
}

void InstancingBasedLines::swap(InstancingBasedLines& other)
Expand Down Expand Up @@ -73,7 +73,7 @@ void InstancingBasedLines::draw(uint viewId) const
}
}

void InstancingBasedLines::update(const std::vector<LinesVertex>& points)
void InstancingBasedLines::setPoints(const std::vector<LinesVertex>& points)
{
mPoints = points;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ TextureBasedLines::TextureBasedLines()
TextureBasedLines::TextureBasedLines(const std::vector<LinesVertex>& points) :
TextureBasedLines()
{
update(points);
setPoints(points);
}

void TextureBasedLines::swap(TextureBasedLines& other)
Expand Down Expand Up @@ -73,7 +73,7 @@ void TextureBasedLines::draw(uint viewId) const
bgfx::submit(viewId, mLinesPH, mIndirect.handle(), 0);
}

void TextureBasedLines::update(const std::vector<LinesVertex>& points)
void TextureBasedLines::setPoints(const std::vector<LinesVertex>& points)
{
allocateAndSetPointsBuffer(points);
allocateAndGenerateTextureBuffer(points.size());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ CPUGeneratedPolylines::CPUGeneratedPolylines(
const std::vector<LinesVertex>& points)
{
assert(bgfx::isValid(mLinesPH));
update(points);
setPoints(points);
}

void CPUGeneratedPolylines::swap(CPUGeneratedPolylines& other)
Expand All @@ -42,7 +42,7 @@ void CPUGeneratedPolylines::swap(CPUGeneratedPolylines& other)
swap(mJointIndices, other.mJointIndices);
}

void CPUGeneratedPolylines::update(const std::vector<LinesVertex>& points)
void CPUGeneratedPolylines::setPoints(const std::vector<LinesVertex>& points)
{
if (points.size() > 1) {
uint bufferVertsSize = (points.size() - 1) * 4 * 15;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ GPUGeneratedPolylines::GPUGeneratedPolylines()
GPUGeneratedPolylines::GPUGeneratedPolylines(
const std::vector<LinesVertex>& points) : Lines()
{
update(points);
setPoints(points);
}

void GPUGeneratedPolylines::swap(GPUGeneratedPolylines& other)
Expand Down Expand Up @@ -69,7 +69,7 @@ void GPUGeneratedPolylines::draw(uint viewId) const
}
}

void GPUGeneratedPolylines::update(const std::vector<LinesVertex>& points)
void GPUGeneratedPolylines::setPoints(const std::vector<LinesVertex>& points)
{
if (points.size() > 1) {
allocateAndSetPointsBuffer(points);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ IndirectBasedPolylines::IndirectBasedPolylines()
IndirectBasedPolylines::IndirectBasedPolylines(
const std::vector<LinesVertex>& points) : IndirectBasedPolylines()
{
update(points);
setPoints(points);
}

void IndirectBasedPolylines::swap(IndirectBasedPolylines& other)
Expand Down Expand Up @@ -84,7 +84,7 @@ void IndirectBasedPolylines::draw(uint viewId) const
}
}

void IndirectBasedPolylines::update(const std::vector<LinesVertex>& points)
void IndirectBasedPolylines::setPoints(const std::vector<LinesVertex>& points)
{
generateIndirectBuffers(points.size());
allocateAndSetPointsBuffer(points);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ InstancingBasedPolylines::InstancingBasedPolylines()
InstancingBasedPolylines::InstancingBasedPolylines(
const std::vector<LinesVertex>& points) : InstancingBasedPolylines()
{
update(points);
setPoints(points);
}

void InstancingBasedPolylines::swap(InstancingBasedPolylines& other)
Expand Down Expand Up @@ -82,7 +82,7 @@ void InstancingBasedPolylines::draw(uint viewId) const
}
}

void InstancingBasedPolylines::update(const std::vector<LinesVertex>& points)
void InstancingBasedPolylines::setPoints(const std::vector<LinesVertex>& points)
{
mPoints = points;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ TextureBasedPolylines::TextureBasedPolylines()
TextureBasedPolylines::TextureBasedPolylines(
const std::vector<LinesVertex>& points) : TextureBasedPolylines()
{
update(points);
setPoints(points);
}

void TextureBasedPolylines::swap(TextureBasedPolylines& other)
Expand Down Expand Up @@ -90,7 +90,7 @@ void TextureBasedPolylines::draw(uint viewId) const
}
}

void TextureBasedPolylines::update(const std::vector<LinesVertex>& points)
void TextureBasedPolylines::setPoints(const std::vector<LinesVertex>& points)
{
if (points.size() > 1) {
allocateAndSetPointsBuffer(points);
Expand Down

0 comments on commit 7819557

Please sign in to comment.