[render] DrawableMeshUniforms update color directly from mesh

cnr-isti-vclab · Jan 27, 2025 · 79b02f0 · 79b02f0
1 parent feff3a8
commit 79b02f0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/vclib/render/include/vclib/bgfx/drawable/drawable_mesh.h b/vclib/render/include/vclib/bgfx/drawable/drawable_mesh.h
@@ -68,7 +68,7 @@ class DrawableMeshBGFX : public AbstractDrawableMesh, public MeshType
         mMRB = MeshRenderBuffers<MeshType>(*this);
         mMRS.setRenderCapabilityFrom(*this);
         mMeshRenderSettingsUniforms.updateSettings(mMRS);
-        mMeshUniforms.update(mMRB);
+        mMeshUniforms.update(*this);
     }
 
     void swap(DrawableMeshBGFX& other)

diff --git a/vclib/render/include/vclib/bgfx/drawable/uniforms/drawable_mesh_uniforms.h b/vclib/render/include/vclib/bgfx/drawable/uniforms/drawable_mesh_uniforms.h
@@ -59,12 +59,14 @@ class DrawableMeshUniforms
     DrawableMeshUniforms() = default;
 
     template<MeshConcept MeshType>
-    void update(const MeshRenderData<MeshType>& mrb)
+    void update(const MeshType& m)
     {
-        std::copy(
-            mrb.meshColorBufferData(),
-            mrb.meshColorBufferData() + 4,
-            mMeshColor);
+        if constexpr (HasColor<MeshType>) {
+            mMeshColor[0] = m.color().redF();
+            mMeshColor[1] = m.color().greenF();
+            mMeshColor[2] = m.color().blueF();
+            mMeshColor[3] = m.color().alphaF();
+        }
     }
 
     void bind() const