added a few features to maybe run WinUAE cputest #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotd666
commented
Jun 5, 2023
jotd666
commented
- don't crash if invalid character printed, print space instead
- support for AllocAbs
- don't crash if invalid character printed, print space instead - support for AllocAbs
reinauer
reviewed
Jun 5, 2023
| "FreeMem: Unknown memory to free: ptr=%06x size=%06x" % (addr, size) | ||
| ) | ||
| pass | ||
| #raise VamosInternalError( |
There was a problem hiding this comment.
Maybe replace with log_exec.info() instead of commenting out?
There was a problem hiding this comment.
Arg sorry. It should just be uncommented and left as it was! It was early tests with a AllocAbs I forgot to restore the old code.
There was a problem hiding this comment.
do you want me to submit another PR with the fix?
There was a problem hiding this comment.
you can update this PR by committing to your branch @jotd666, no need to create a new PR.
There was a problem hiding this comment.
I have amended my previous commit. Does that work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.