Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust integration with launcher #401

Merged
merged 12 commits into from
Aug 3, 2023
Merged

Rust integration with launcher #401

merged 12 commits into from
Aug 3, 2023

Conversation

fayeed
Copy link
Member

@fayeed fayeed commented Jul 27, 2023

  • Adds rust-executor to the launcher.
  • Updated rust-executor to work with launcher using tokio.
  • Updated logging for JSCore & rust.

lucksus
lucksus previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! But the error (about not being able to create publishing agent) should be fixed. Or is this failing in the rust refactor branch as well?

jdeepee
jdeepee requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@jdeepee jdeepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the only missing change I can see is updating the clear_state function inside ui/src/commands/app.rs

@jdeepee jdeepee merged commit 1c5a57c into rust-refactor Aug 3, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdeepee jdeepee jdeepee requested changes

@lucksus lucksus lucksus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fayeed @lucksus @jdeepee