-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nillion file store view #468
Open
jdeepee
wants to merge
20
commits into
dev
Choose a base branch
from
add-nillion-file-view
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-file-store plugin and unbundled nillion client code
…c for resolving nillion-file-store
…ide of Nillion client to work
✅ Deploy Preview for fluxsocial-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fluxdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is excellent and opens doors to experimenting with other Cosmos SDK chains like https://jackalprotocol.com and https://akash.network/ |
# Conflicts: # app/package.json # app/src/ad4mConnect.ts # app/src/utils/fetchFluxApp.ts # yarn.lock
…to add-nillion-file-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a file storage view into Flux.
This needed to be added as a core package directly inside flux due to the use of SharedArray buffer in @nillion/client-web. To use SharedArray buffer we are required to set strict cors rules from the host that will serve the UI. This means that if we serve from jsdeliver (as we do for other community packages), we will for one not have the correct cors rules and secondly will not be able to setup the required proxy to the nillion blockchain.
There is also some custom build work going on here, mainly that we avoid bundling the @nillion/client-web code with the plugin as @nillion/client-web does not work with vite bundle processes. Instead of bundling @nillion/client-web we just serve it out from the /dist directory and pull the files as needed by the plugin at runtime. Looking inside @nillion/client-web it seems most of the code is pre-bundled anyhow.
This implementation is as close to production ready as possible, and features:
To get up and running with keplr and get some nillion testnet fuel you can follow this guide.
This PR is only currently blocked by a review from the larger team & release of ADAM version 0.10.0 with the latest ad4m-connect & new logic inside executor to manage specific CORS rules for Flux.