Configure controller host entry via nixos option #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
Sep 5, 2025
phip1611
reviewed
Sep 5, 2025
| { | ||
| options.openstack = { | ||
| controllerIP = mkOption { | ||
| type = types.str; |
Member
There was a problem hiding this comment.
Suggested change
| type = types.str; | |
| type = types.nonEmptyStr; |
phip1611
reviewed
Sep 5, 2025
Previously, a user not using the testing modules had to set the hosts entry himself, while with the new module we get an error if that controller host is not configured. On-behalf-of: SAP stefan.kober@sap.com
in both compute and controller. This way, a user of any of this modules has to set an IP for the controller. Otherwise, the services cannot function properly. On-behalf-of: SAP stefan.kober@sap.com
We set some actual controller IP via the new module, allowing us to remove the custom extraHosts entry that was used previously. On-behalf-of: SAP stefan.kober@sap.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using the
testingmodules, the openstack systemd services could not come up because they couldn't reach thecontroller. The user had to set some hosts entry himself so thatcontrolleris reachable via name.We add some nixos option to configure a
controllerIPwhich will result in the proper hosts entry being made by nix. Further, a nice error is now printed if thecontrollerIPis not set.See #12