Skip to content

Conversation

@hertrste
Copy link
Contributor

Add commit liniting for compliance.

phip1611 and others added 3 commits March 21, 2025 10:07
We at Cyberus commit with our @cyberus-technology.de emails. To be
compliant with SAP, we use gitlint to check if we include the
mandatory "On-behalf-of: SAP" line in each commit.

To develop and play around with gitlint, you may use
- `gitlint --commits HEAD~1..HEAD`
- `gitlint --debug`

On-behalf-of: SAP philipp.schuster@sap.com
On-behalf-of: SAP stefan.kober@sap.com
On-behalf-of: SAP stefan.kober@sap.com
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have you tested pushing a non-compliant commit and observed the CI results?

@hertrste
Copy link
Contributor Author

LGTM! Have you tested pushing a non-compliant commit and observed the CI results?

Yes! Already checked and works as expected

@phip1611
Copy link
Member

Nice, then we are good to go

@hertrste hertrste merged commit 50ad7c1 into main Mar 21, 2025
6 checks passed
@hertrste hertrste deleted the commit-lint branch March 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants