Skip to content

Fix integer overflow on 32-bit architectures #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix integer overflow on 32-bit architectures #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da77b44
Fix 32-bit architecture build: use int64 for position variables
chrislusf Oct 21, 2025
c0df054
Fix 32-bit architecture build: use int64 for flag types
chrislusf Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/sql/lexbase/encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
)

// EncodeFlags influence the formatting of strings and identifiers.
type EncodeFlags int
type EncodeFlags int64

// HasFlags tests whether the given flags are set.
func (f EncodeFlags) HasFlags(subset EncodeFlags) bool {
Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/sem/tree/format.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
)

// FmtFlags carries options for the pretty-printer.
type FmtFlags int
type FmtFlags int64

// HasFlags tests whether the given flags are all set.
func (f FmtFlags) HasFlags(subset FmtFlags) bool {
Expand Down
6 changes: 3 additions & 3 deletions pkg/util/tsearch/eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ func (e *tsEvaluator) evalFollowedBy(
if lExhausted && rExhausted {
break
}
var lPos, rPos int
var lPos, rPos int64
if !lExhausted {
lPos = int(lPositions.positions[lIdx].position) + lOffset
lPos = int64(lPositions.positions[lIdx].position) + int64(lOffset)
} else {
// Quit unless we're outputting all of the RHS, which we will if we have
// a negative match on the LHS.
Expand All @@ -180,7 +180,7 @@ func (e *tsEvaluator) evalFollowedBy(
lPos = math.MaxInt64
}
if !rExhausted {
rPos = int(rPositions.positions[rIdx].position) + rOffset
rPos = int64(rPositions.positions[rIdx].position) + int64(rOffset)
} else {
// Quit unless we're outputting all of the LHS, which we will if we have
// a negative match on the RHS.
Expand Down