fixed #17876: [bug][Tween] callFunc before updateUntil may be invoked more than once. #18179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumganhar
changed the title
|
dumganhar
commented
Jan 13, 2025
| if (t < 1) { | ||
| this._elapsed -= dt; | ||
| } else { | ||
| this._elapsed = this._startTime + this._duration; |
There was a problem hiding this comment.
If t is 1, that indicates the current ActionInterval action is at the end, so its _elapsed should be start time + duration.
dumganhar
commented
Jan 13, 2025
| isDone (): boolean { | ||
| return (this._elapsed >= this._duration); | ||
| override isDone (): boolean { | ||
| return this._elapsed >= this._duration && !this.isUnknownDuration(); |
There was a problem hiding this comment.
If an action 's duration is unknown, we should not mark it as DONE until it isn't an unknown duration action.
minggo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #17876
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: