Skip to content

Caching getSystemInfoSystem information in mini game platforms#18781

Merged
star-e merged 6 commits intococos:v3.8.8from
qiuguohua:v3.8.8_fix_getsysteminfo
Aug 21, 2025
Merged

Caching getSystemInfoSystem information in mini game platforms#18781
star-e merged 6 commits intococos:v3.8.8from
qiuguohua:v3.8.8_fix_getsysteminfo

Conversation

@qiuguohua
Copy link
Copy Markdown
Contributor

@qiuguohua qiuguohua commented Jun 13, 2025

Re: #

#18084


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@qiuguohua qiuguohua requested a review from star-e June 13, 2025 03:10
@qiuguohua
Copy link
Copy Markdown
Contributor Author

#18780

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 13, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1005977 bytes 1008438 bytes ⚠️ +2461 bytes
2D All (legacy pipeline) 2671067 bytes 2673540 bytes ⚠️ +2473 bytes
2D All (new pipeline) 2761184 bytes 2763654 bytes ⚠️ +2470 bytes
(2D + 3D) All 10017488 bytes 10019961 bytes ⚠️ +2473 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16839109 bytes 16839109 bytes ✅ 0 bytes

Interface Check Report

This pull request does not change any public interfaces !

@star-e
Copy link
Copy Markdown
Contributor

star-e commented Jun 18, 2025

Will be merged after pr test.

@qiuguohua qiuguohua force-pushed the v3.8.8_fix_getsysteminfo branch from e6a7813 to fc2cf72 Compare June 18, 2025 07:39
@qiuguohua
Copy link
Copy Markdown
Contributor Author

#18740

@star-e
Copy link
Copy Markdown
Contributor

star-e commented Aug 20, 2025

@cocos-robot run-test-cases-custom

1 similar comment
@star-e
Copy link
Copy Markdown
Contributor

star-e commented Aug 20, 2025

@cocos-robot run-test-cases-custom

@github-actions
Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL tween-custom-progress
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions
Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS PASS
wechatgame PASS PASS FAIL bloom

@star-e star-e merged commit 36e6d0e into cocos:v3.8.8 Aug 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants