3.4 version OHOS adaptation #20820
3.4 version OHOS adaptation #20820
Conversation
3.4 version OHOS adaptation
add appveyor.yml
tests/lua-tests/src/controller.lua
Outdated
| @@ -1,4 +1,7 @@ | |||
|
|
|||
| -- jit off | |||
| local jit = require("jit") | |||
| jit.off() | |||
There was a problem hiding this comment.
JIT Capability Shutdown
Reason: To prevent malware from bypassing app market reviews by abusing JIT (RWX) memory to execute arbitrary code
There was a problem hiding this comment.
But why only this test case need to disable jit?
There was a problem hiding this comment.
disable jit here will apply to all test cases.
There was a problem hiding this comment.
I think it is better:
- disable it in mainmenu.lua is better
- only disable it on OHOS
There was a problem hiding this comment.
How can I only use the lua vm?
There was a problem hiding this comment.
Your meaning is that in CMake, we should not link LuaJIT? Will this have other impacts? LuaJIT has also made optimizations in other aspects.
There was a problem hiding this comment.
Yep, like iOS, it uses lua instead of luajit.
There was a problem hiding this comment.
It's also ok to use it as current implementation. Please make a decision and modify all PR.
There was a problem hiding this comment.
Also need use luajit. After disable jit, luaJIT remains more optimized. please see this bloc https://blog.csdn.net/u014397684/article/details/125686988
change sys_string "HarmonyOS Next"
change "jit off" to mainMenu only ohos
3.4 version OHOS adaptation