3.12 version OHOS adaptation #20825
Open
3.12 version OHOS adaptation #20825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: @wanghui187 <348582973@qq.com>
Signed-off-by: @wanghui187 <348582973@qq.com>
Signed-off-by: @wanghui187 <348582973@qq.com>
Signed-off-by: @wanghui187 <348582973@qq.com>
minggo
reviewed
Dec 25, 2024
| @@ -362,8 +362,11 @@ GLProgramState::GLProgramState() | |||
| , _vertexAttribsFlags(0) | |||
| , _glprogram(nullptr) | |||
| , _nodeBinding(nullptr) | |||
| #if (CC_TARGET_PLATFORM == CC_PLATFORM_OHOS) | |||
| , _backToForegroundlistener(nullptr) | |||
| #endif | |||
There was a problem hiding this comment.
Why only initialize on OHOS?
minggo
reviewed
Dec 25, 2024
| @@ -54,10 +54,13 @@ MeshCommand::MeshCommand() | |||
| , _vao(0) | |||
| , _material(nullptr) | |||
| , _stateBlock(nullptr) | |||
| #if (CC_TARGET_PLATFORM == CC_PLATFORM_OHOS) | |||
| , _rendererRecreatedListener(nullptr) | |||
| #endif | |||
There was a problem hiding this comment.
Why only initialize on OHOS?
minggo
reviewed
Dec 25, 2024
|
|
||
| if(OHOS) | ||
| target_link_libraries(luacocos2d ext_luajit) | ||
| # luajit比lua多一个头文件luajit.h，在../../../external/lua/luajit/src下，暂时没有用到 |
There was a problem hiding this comment.
Please don't use Chinese. Please check all files.
minggo
reviewed
Dec 25, 2024
| @@ -58,6 +58,8 @@ elseif target == cc.PLATFORM_OS_WINRT then | |||
| device.platform = "winrt" | |||
| elseif target == cc.PLATFORM_OS_WP8 then | |||
| device.platform = "wp8" | |||
| elseif target == cc.PLATFORM_OS_OHOS then | |||
| device.platform = "harmony" | |||
There was a problem hiding this comment.
Should change to HarmonyOS Next?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.