Skip to content

Conversation

malteos
Copy link
Collaborator

@malteos malteos commented Aug 15, 2025

Moved to #54

@wumpus
Copy link
Member

wumpus commented Aug 17, 2025

You're on the right track.

I see that we need to fix the tests, that should be done in a separate PR.

@malteos malteos marked this pull request as draft August 22, 2025 12:13
@malteos malteos marked this pull request as ready for review August 22, 2025 14:42
@malteos malteos changed the title feat: Adding filter_cdx and warc_by_cdx commands (WIP) feat: Adding filter_cdx and warc_by_cdx commands Aug 26, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 54.12844% with 350 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.74%. Comparing base (e5d122a) to head (d9adf03).

Files with missing lines Patch % Lines
cdx_toolkit/warcer_by_cdx/aioboto3_warcer.py 12.25% 136 Missing ⚠️
cdx_toolkit/filter_cdx/__init__.py 22.41% 90 Missing ⚠️
cdx_toolkit/warcer_by_cdx/aioboto3_utils.py 45.00% 44 Missing ⚠️
cdx_toolkit/warcer_by_cdx/aioboto3_writer.py 22.72% 34 Missing ⚠️
cdx_toolkit/warcer_by_cdx/cdx_utils.py 57.50% 17 Missing ⚠️
cdx_toolkit/utils.py 75.00% 9 Missing ⚠️
cdx_toolkit/warcer_by_cdx/__init__.py 91.93% 5 Missing ⚠️
cdx_toolkit/warc.py 84.00% 4 Missing ⚠️
cdx_toolkit/warcer_by_cdx/warc_utils.py 88.88% 4 Missing ⚠️
cdx_toolkit/warcer_by_cdx/fsspec_warcer.py 95.83% 3 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (e5d122a) and HEAD (d9adf03). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e5d122a) HEAD (d9adf03)
8 7
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   95.66%   63.74%   -31.93%     
===========================================
  Files           7       19       +12     
  Lines         877     1597      +720     
===========================================
+ Hits          839     1018      +179     
- Misses         38      579      +541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@malteos
Copy link
Collaborator Author

malteos commented Sep 19, 2025

Moved to #54

@malteos malteos closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants