Skip to content

Conversation

@malteos
Copy link
Collaborator

@malteos malteos commented Nov 19, 2025

This PR integrates a couple of general changes from the EOT PR (#54):

  • Settings variables are loaded from environment variables in settings.py
  • Common CLI methods are moved to utils.py
  • Read and write to S3 (via fsspec).
  • Missing writer.close() statement is added to CLI and example.

@malteos malteos changed the title feat: Adding settings, utils, and writer close feat: Adding settings, utils, write to S3, and writer close Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.64%. Comparing base (b6f5f02) to head (4e660a3).

Files with missing lines Patch % Lines
cdx_toolkit/warc.py 93.10% 2 Missing ⚠️
cdx_toolkit/cli.py 75.00% 1 Missing ⚠️
cdx_toolkit/commoncrawl.py 80.00% 1 Missing ⚠️
cdx_toolkit/utils.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   95.78%   95.64%   -0.14%     
==========================================
  Files           7        9       +2     
  Lines         877      918      +41     
==========================================
+ Hits          840      878      +38     
- Misses         37       40       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@malteos malteos requested a review from wumpus December 8, 2025 17:52
@malteos
Copy link
Collaborator Author

malteos commented Dec 8, 2025

Given that the test coverage check fails on this one, what about adjusting the coverage check to a fixed value instead of the last coverage value?

@wumpus
Copy link
Member

wumpus commented Dec 11, 2025

While the coverage check failed, I don't think it will cause a problem in the next CI run? It's just a slightly easier hurdle next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants