Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add more guidance around sending email via templates #24

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

patcon
Copy link
Collaborator

@patcon patcon commented Nov 17, 2020

To Do

  • mvp component design
  • demo component to @s-kennedy (feedback)
    • use better "template preview" link
    • open links in _blank tab
    • mention Mailjet to hint at external system
    • warn about login being required (tooltip?)
    • other discussion items
      • listing for failed/bounced/success emails
      • confirms no good way to link to this within mailjet (no way to filter)
  • seek feedback from StART team
  • if get go-ahead
    • add server logic for passing template variables
    • maybe: display template labels in component
  • fix storybook workflow
  • auto-link hosted storybook from PRs
  • add new storybook build workflow for send_email app

@s-kennedy s-kennedy temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 20:36 Inactive
@patcon
Copy link
Collaborator Author

patcon commented Nov 17, 2020

Had quick review with @s-kennedy. loose notes:

  • use better "template preview" link
  • open links in _blank tab
  • mention Mailjet to hint at external system
  • warn about login being required (tooltip?)
  • other discussion items

@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 20:58 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:03 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:08 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:11 Inactive
@patcon patcon force-pushed the send-email-support branch from f3a6f41 to f16813b Compare November 17, 2020 21:11
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:11 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:18 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:21 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 21:26 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 22:22 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 17, 2020 22:44 Inactive
@patcon patcon temporarily deployed to start-dashbo-send-email-pdy6hu November 18, 2020 01:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants