Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Dec 2, 2025

This PR enables the plugin to use our local TS code instead of a installed NPM package.
I also renamed AutorunExecutor to CliExecutor

depends on #1159

Followup PR will cover testing the logic in runCliExecutor.

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2025

View your CI Pipeline Execution ↗ for commit 4a483a6

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 23s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 24s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-04 22:49:40 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1161

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1161

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1161

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1161

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1161

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1161

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1161

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1161

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1161

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1161

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1161

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1161

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1161

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1161

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1161

commit: 4a483a6

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit bd60c26 with previous commit a863abb.

💼 Project nx-plugin

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 85 🟡 85 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 85 🟡 85 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 79.3 % 🟨 79.9 % ↑ +0.7 %
Code coverage Branch coverage 🟨 76.4 % 🟨 76.4 % ↑ +0.1 %

445 other audits are unchanged.


13 other projects are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit bd60c26 with previous commit a863abb.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 42 🔴 39 ↓ −2.3
Code coverage 🟡 89 🟡 89 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed, 21 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 42 🔴 39 ↓ −2.3
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 5.8 s 🟥 6.4 s ↑ +9.7 %
Lighthouse Total Blocking Time 🟥 1,120 ms 🟥 1,240 ms ↑ +10.9 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↑ +3.1 %
Lighthouse Time to Interactive 🟥 12.4 s 🟥 12.7 s ↑ +2.7 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↓ −0.1 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.5 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,045 KiB 🟩 Total size was 2,032 KiB ↓ −0.6 %
Lighthouse Server Backend Latencies 🟩 1,180 ms 🟩 350 ms ↓ −70.1 %
Lighthouse Minimizes main-thread work 🟥 8.0 s 🟥 8.7 s ↑ +8.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 3.1 s 🟥 3.5 s ↑ +12.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +2.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +100 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 186 KiB 🟥 Potential savings of 186 KiB ↑ +16.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 98 KiB 🟥 Potential savings of 92 KiB ↑ +33.3 %
Lighthouse Max Potential First Input Delay 🟥 1,060 ms 🟥 1,210 ms ↑ +13.4 %
Lighthouse Initial server response time was short 🟩 Root document took 440 ms 🟩 Root document took 580 ms ↑ +29.6 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 70 ms ↑ +734.9 %
Lighthouse Largest Contentful Paint 🟥 11.3 s 🟥 11.3 s ↑ +0.3 %
TypeScript Semantic errors 🟥 2623 errors 🟥 2596 errors ↓ −1 %
TypeScript No implicit any errors 🟥 96 errors 🟥 94 errors ↓ −2.1 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 29 vulnerabilities (1 critical, 5 high, 18 moderate, 5 low) 🟥 30 vulnerabilities (1 critical, 6 high, 18 moderate, 5 low) ↑ +3.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,358 elements 🟥 2,359 elements ↑ +0.1 %
Axe Accessibility Deprecated ARIA roles must not be used 🟩 5 elements 🟩 6 elements ↑ +20 %
Axe Accessibility Required ARIA attributes must be provided 🟩 5 elements 🟩 6 elements ↑ +20 %
Axe Accessibility ARIA roles used must conform to valid values 🟩 5 elements 🟩 6 elements ↑ +20 %
Axe Accessibility Inline text spacing must be adjustable with custom stylesheets 🟩 40 elements 🟩 41 elements ↑ +2.5 %

651 other audits are unchanged.

# Conflicts:
#	packages/nx-plugin/src/executors/cli/executor.ts
#	packages/nx-plugin/src/executors/cli/executor.unit.test.ts
@BioPhoton BioPhoton marked this pull request as ready for review December 4, 2025 17:43
@BioPhoton BioPhoton requested a review from matejchalk December 4, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants