Skip to content

[Downey] SignUpView 구조 재설계 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dahun-lee-daji wants to merge 15 commits into
base: dahun-lee-daji
Choose a base branch
from
Open

[Downey] SignUpView 구조 재설계 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
eb25db1
불필요 코드 삭제, method명 변경
dahun-lee-daji Apr 1, 2021
bb74bbc
Custom TextField 정의
dahun-lee-daji Apr 1, 2021
fed1c7b
InfromationLabel 속성 설정 메소드 제거
dahun-lee-daji Apr 1, 2021
3268fbc
메소드 명 변경, IBOutletCollection 타입 변경
dahun-lee-daji Apr 1, 2021
0296125
ComplianceChecker로직 변경
dahun-lee-daji Apr 1, 2021
9f47314
observer pattern 삭제
dahun-lee-daji Apr 1, 2021
f63b565
Observer Pattern 잔여 코드 삭제
dahun-lee-daji Apr 1, 2021
90f53e9
불필요한 코드 제거
dahun-lee-daji Apr 1, 2021
7cd6c62
정규 표현식 메소드 분리
dahun-lee-daji Apr 1, 2021
88f6c3f
폴더정리, 에러의 다형성 구현
dahun-lee-daji Apr 2, 2021
1b15ca0
NetworkManager: Singleton, serialize 기능 분리
dahun-lee-daji Apr 2, 2021
02f9dc6
네트워크 요청에서 판단 로직 분리
dahun-lee-daji Apr 2, 2021
b51b618
postUser Result<>적용
dahun-lee-daji Apr 4, 2021
a34f127
UI Update 주체 변경
dahun-lee-daji Apr 5, 2021
d0d9a00
반복되는 내용 메서드화
dahun-lee-daji Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added SignUp/.DS_Store
View file
Open in desktop
Binary file not shown.
32 changes: 20 additions & 12 deletions SignUp/SignUp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
B075D0F326119A7F00731DAC /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = B075D0F226119A7F00731DAC /* Assets.xcassets */; };
B075D0F626119A7F00731DAC /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = B075D0F426119A7F00731DAC /* LaunchScreen.storyboard */; };
B075D1012611BBC700731DAC /* TextFieldDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D1002611BBC700731DAC /* TextFieldDelegate.swift */; };
B075D1042611BEB600731DAC /* Notification+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D1032611BEB600731DAC /* Notification+Extension.swift */; };
B075D1072611D07800731DAC /* textFormError.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D1062611D07800731DAC /* textFormError.swift */; };
B075D10B261207A600731DAC /* ComplianceChecker.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D10A261207A600731DAC /* ComplianceChecker.swift */; };
B075D10E261209C300731DAC /* UITextField+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D10D261209C300731DAC /* UITextField+Extension.swift */; };
B075D11126120A5900731DAC /* UILabel+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D11026120A5900731DAC /* UILabel+Extension.swift */; };
B075D1162612F4AD00731DAC /* UserInfomation.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D1152612F4AD00731DAC /* UserInfomation.swift */; };
B075D11A261300FB00731DAC /* NetworkManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D119261300FB00731DAC /* NetworkManager.swift */; };
B075D12026158BED00731DAC /* SignUpTextField.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D11F26158BED00731DAC /* SignUpTextField.swift */; };
B075D1262616003400731DAC /* ErrorCheckResult.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D1252616003400731DAC /* ErrorCheckResult.swift */; };
B075D12B26195E2200731DAC /* Notification.name+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = B075D12A26195E2100731DAC /* Notification.name+Extension.swift */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
Expand All @@ -33,13 +33,13 @@
B075D0F526119A7F00731DAC /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
B075D0F726119A7F00731DAC /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
B075D1002611BBC700731DAC /* TextFieldDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextFieldDelegate.swift; sourceTree = "<group>"; };
B075D1032611BEB600731DAC /* Notification+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Notification+Extension.swift"; sourceTree = "<group>"; };
B075D1062611D07800731DAC /* textFormError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = textFormError.swift; sourceTree = "<group>"; };
B075D10A261207A600731DAC /* ComplianceChecker.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ComplianceChecker.swift; sourceTree = "<group>"; };
B075D10D261209C300731DAC /* UITextField+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UITextField+Extension.swift"; sourceTree = "<group>"; };
B075D11026120A5900731DAC /* UILabel+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UILabel+Extension.swift"; sourceTree = "<group>"; };
B075D1152612F4AD00731DAC /* UserInfomation.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserInfomation.swift; sourceTree = "<group>"; };
B075D119261300FB00731DAC /* NetworkManager.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkManager.swift; sourceTree = "<group>"; };
B075D11F26158BED00731DAC /* SignUpTextField.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SignUpTextField.swift; sourceTree = "<group>"; };
B075D1252616003400731DAC /* ErrorCheckResult.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ErrorCheckResult.swift; sourceTree = "<group>"; };
B075D12A26195E2100731DAC /* Notification.name+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Notification.name+Extension.swift"; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -86,27 +86,35 @@
B075D0FE26119C0200731DAC /* SignUpView */ = {
isa = PBXGroup;
children = (
B075D11E26158BDA00731DAC /* View */,
B075D0ED26119A7D00731DAC /* SignUpViewController.swift */,
B075D0EF26119A7D00731DAC /* Main.storyboard */,
B075D1002611BBC700731DAC /* TextFieldDelegate.swift */,
B075D1062611D07800731DAC /* textFormError.swift */,
B075D10A261207A600731DAC /* ComplianceChecker.swift */,
B075D119261300FB00731DAC /* NetworkManager.swift */,
B075D1152612F4AD00731DAC /* UserInfomation.swift */,
B075D1252616003400731DAC /* ErrorCheckResult.swift */,
);
path = SignUpView;
sourceTree = "<group>";
};
B075D1132612121800731DAC /* Extension */ = {
isa = PBXGroup;
children = (
B075D1032611BEB600731DAC /* Notification+Extension.swift */,
B075D10D261209C300731DAC /* UITextField+Extension.swift */,
B075D11026120A5900731DAC /* UILabel+Extension.swift */,
B075D12A26195E2100731DAC /* Notification.name+Extension.swift */,
);
path = Extension;
sourceTree = "<group>";
};
B075D11E26158BDA00731DAC /* View */ = {
isa = PBXGroup;
children = (
B075D11F26158BED00731DAC /* SignUpTextField.swift */,
);
path = View;
sourceTree = "<group>";
};
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
Expand Down Expand Up @@ -180,14 +188,14 @@
B075D10B261207A600731DAC /* ComplianceChecker.swift in Sources */,
B075D0EE26119A7D00731DAC /* SignUpViewController.swift in Sources */,
B075D0EA26119A7D00731DAC /* AppDelegate.swift in Sources */,
B075D1072611D07800731DAC /* textFormError.swift in Sources */,
B075D12026158BED00731DAC /* SignUpTextField.swift in Sources */,
B075D12B26195E2200731DAC /* Notification.name+Extension.swift in Sources */,
B075D1262616003400731DAC /* ErrorCheckResult.swift in Sources */,
B075D11A261300FB00731DAC /* NetworkManager.swift in Sources */,
B075D1162612F4AD00731DAC /* UserInfomation.swift in Sources */,
B075D1012611BBC700731DAC /* TextFieldDelegate.swift in Sources */,
B075D10E261209C300731DAC /* UITextField+Extension.swift in Sources */,
B075D1042611BEB600731DAC /* Notification+Extension.swift in Sources */,
B075D0EC26119A7D00731DAC /* SceneDelegate.swift in Sources */,
B075D11126120A5900731DAC /* UILabel+Extension.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
Binary file modified ...codeproj/project.xcworkspace/xcuserdata/idahun.xcuserdatad/UserInterfaceState.xcuserstate
View file
Open in desktop
Binary file not shown.
18 changes: 0 additions & 18 deletions SignUp/SignUp/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,28 +9,10 @@ import UIKit

@main
class AppDelegate: UIResponder, UIApplicationDelegate {



func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.
return true
}

// MARK: UISceneSession Lifecycle

func application(_ application: UIApplication, configurationForConnecting connectingSceneSession: UISceneSession, options: UIScene.ConnectionOptions) -> UISceneConfiguration {
// Called when a new scene session is being created.
// Use this method to select a configuration to create the new scene with.
return UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)
}

func application(_ application: UIApplication, didDiscardSceneSessions sceneSessions: Set<UISceneSession>) {
// Called when the user discards a scene session.
// If any sessions were discarded while the application was not running, this will be called shortly after application:didFinishLaunchingWithOptions.
// Use this method to release any resources that were specific to the discarded scenes, as they will not return.
}


}

15 changes: 0 additions & 15 deletions SignUp/SignUp/Extension/Notification+Extension.swift
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions SignUp/SignUp/Extension/Notification.name+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//
// Notification.name+Extension.swift
// SignUp
//
// Created by 이다훈 on 2021/04/04.
//

import Foundation

extension Notification.Name {
static let uiUpdate = Notification.Name.init("uiUpdate")
static let nextButtonEnableCheck = Notification.Name.init("nextButtonEnableCheck")
}
Copy link
Contributor

@godrm godrm Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 노티는 누가 보내는 건가요? 누가 받는건가요?
어느 타입과 관련이 높을까요? 응집도를 높여서 타입에 선언하는 걸 고려해보세요.
extension 자체가 이 노티와 관련된 타입에 있으면 좋습니다.

15 changes: 0 additions & 15 deletions SignUp/SignUp/Extension/UILabel+Extension.swift
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion SignUp/SignUp/Extension/UITextField+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import UIKit

extension UITextField {
func changeBorderColor(color : CGColor) {
func changeBorder(color : CGColor) {
self.layer.borderWidth = 1
self.layer.borderColor = color
}
Expand Down
39 changes: 0 additions & 39 deletions SignUp/SignUp/SceneDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,45 +8,6 @@
import UIKit

class SceneDelegate: UIResponder, UIWindowSceneDelegate {

var window: UIWindow?


func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
// Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`.
// If using a storyboard, the `window` property will automatically be initialized and attached to the scene.
// This delegate does not imply the connecting scene or session are new (see `application:configurationForConnectingSceneSession` instead).
guard let _ = (scene as? UIWindowScene) else { return }
}

func sceneDidDisconnect(_ scene: UIScene) {
// Called as the scene is being released by the system.
// This occurs shortly after the scene enters the background, or when its session is discarded.
// Release any resources associated with this scene that can be re-created the next time the scene connects.
// The scene may re-connect later, as its session was not necessarily discarded (see `application:didDiscardSceneSessions` instead).
}

func sceneDidBecomeActive(_ scene: UIScene) {
// Called when the scene has moved from an inactive state to an active state.
// Use this method to restart any tasks that were paused (or not yet started) when the scene was inactive.
}

func sceneWillResignActive(_ scene: UIScene) {
// Called when the scene will move from an active state to an inactive state.
// This may occur due to temporary interruptions (ex. an incoming phone call).
}

func sceneWillEnterForeground(_ scene: UIScene) {
// Called as the scene transitions from the background to the foreground.
// Use this method to undo the changes made on entering the background.
}

func sceneDidEnterBackground(_ scene: UIScene) {
// Called as the scene transitions from the foreground to the background.
// Use this method to save data, release shared resources, and store enough scene-specific state information
// to restore the scene back to its current state.
}


}

Loading