fix(tmux): handle \r line endings and missing pane_title in list-panes#2284
Open
MoerAI wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(tmux): handle \r line endings and missing pane_title in list-panes#2284MoerAI wants to merge 1 commit intocode-yeongyu:devfrom
MoerAI wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Strip \r characters from list-panes output to handle Windows-style line endings. Also relax field count check from 9 to 8 to handle cases where pane_title is empty or missing, which caused the parser to drop pane rows and fail to determine the main pane in single-pane sessions. Fixes code-yeongyu#2241
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The changes correctly handle CRLF line endings and optional pane titles, fixing a bug where valid panes were skipped. Minimal risk as it only improves the robustness of tmux output parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\rcharacters fromlist-panesoutput to handle Windows-style line endings that caused pane rows to be droppedpane_titleare still parsed correctlymainPaneresolution failed because all pane rows were dropped by the parserRoot cause: In some environments,
tmux list-panesoutput contains\r\nline endings or emptypane_titlevalues. The parser'ssplit("\n")left trailing\rin field values (corrupting parseInt), and thefields.length < 9check dropped rows wherepane_titlewas absent.Fixes #2241
Summary by cubic
Fix tmux list-panes parsing by removing \r characters and handling missing pane_title. This restores main pane detection and prevents the first subagent split from failing in single-pane sessions.
Written for commit e1952d3. Summary will update on new commits.