Qnrr 396 프로필 수정 모달 placeholder 변경#100
Merged
Conversation
aken-you
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 연관된 이슈
Qnrr 396
☘️ 작업 내용
🍀 논의사항
요구사항이 추가될 때마다 FormField의 props가 추가되어 유지보수하기 어렵지 않을까 생각되는데요 🤔
FormField 안의 반환하는 컴포넌트의 공통점은 폼의 field입니다. 근데 각자 다르게 동작하기 때문에 한 컴포넌트에서 관리할 필요가 있을까 싶습니다.
두 분은 어떻게 생각하시나요?