fix: 스터디 참가 여부 api 수정#118
Merged
Conversation
aken-you
approved these changes
Aug 5, 2025
|
|
||
| // 스터디 주간 참여 유무 확인 query | ||
| export const useWeeklyParticipation = (params: GetDailyStudyDetailParams2) => { | ||
| export const useWeeklyParticipation = (params: string) => { |
Contributor
There was a problem hiding this comment.
이런 경우에는 따로 타입 정의를 안해도 되는걸까요?!
Contributor
Author
There was a problem hiding this comment.
모르겠습니다... 저도 고민했던 부분인데
값을 하나만 입력하는 경우라 유지보수 차원에서는 타입 정의를 하는 게 좋을 수 있지만
또 한편으로는 너무 과하게 타입 분리한다는 생각도 들어서...
이건 그냥 의견 따라 좀 더 맞다고 생각하는 쪽으로 변경하겠습니다
Contributor
There was a problem hiding this comment.
저도 민주님이랑 같은 의견입니다! 너무 과하게 타입 컨벤션을 지키려고 하는걸까 싶기도 해서요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 연관된 이슈
QNRR-435☘️ 작업 내용
-[x] 스터디 참가 여부 params 수정
🍀 참고사항
백엔드에 반영된 형태로 api 수정했습니다.
머지 되면 바로 운영서버에 반영하도록 하겠습니다.