Closed
Conversation
백엔드 api 업데이트 후 수정이 필요합니다
aken-you
reviewed
Sep 28, 2025
Comment on lines
+70
to
+79
| disabled={props.disabled} | ||
| className={cn( | ||
| inputVariants({ | ||
| color, | ||
| size, | ||
| appearance, | ||
| disabled: props.disabled ? true : undefined, | ||
| }), | ||
| className, | ||
| )} |
Contributor
There was a problem hiding this comment.
disabled를 함수 파라미터에서 가져오는 건 어떨까요?
Suggested change
| disabled={props.disabled} | |
| className={cn( | |
| inputVariants({ | |
| color, | |
| size, | |
| appearance, | |
| disabled: props.disabled ? true : undefined, | |
| }), | |
| className, | |
| )} | |
| disabled={disabled} | |
| className={cn( | |
| inputVariants({ | |
| color, | |
| size, | |
| appearance, | |
| disabled: disabled ? true : undefined, | |
| }), | |
| className, | |
| )} |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🌱 연관된 이슈
이슈 없이 개별 생성
☘️ 작업 내용
일단 작업한 모달 올려뒀습니다.
빌드 시 오류 나는 것 지극히 정상입니다. 빌드 안해도 오류 뜨는 게 정상입니다.
스키마가 api와 ui와 달라 오류가 나기 때문입니다...
확인하시라고 올려뒀습니다.
수아님 radio 버튼 추가되면 todo로 적어둔 부분 수정해서 커밋 올리도록 하겠습니다.