Qnrr 354 코드 리뷰하면 PR 작성자에게 DM 전송하는 자동화 안되는 문제#83
Hidden character warning
The head ref may contain hidden characters: "QNRR-354-\uc720\uc218\uc544-\ucf54\ub4dc-\ub9ac\ubdf0\ud558\uba74-pr-\uc791\uc131\uc790\uc5d0\uac8c-dm-\uc804\uc1a1\ud558\ub294-\uc790\ub3d9\ud654-\uc548\ub418\ub294-\ubb38\uc81c"
Merged
Conversation
aken-you
changed the title
Contributor
|
코멘트 달아보겠습니다! |
- slack bot이 사용자에게 DM을 보내기 전에, 사용자와의 DM 채널 id가 필요하여 조회
aken-you
force-pushed
the
QNRR-354-유수아-코드-리뷰하면-pr-작성자에게-dm-전송하는-자동화-안되는-문제
branch
from
0bf1e2a to
a43551e
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
aken-you
force-pushed
the
QNRR-354-유수아-코드-리뷰하면-pr-작성자에게-dm-전송하는-자동화-안되는-문제
branch
2 times, most recently
from
51775a3 to
a43551e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 연관된 이슈
Qnrr 354
☘️ 작업 내용
팀원이 코드리뷰를 하면 PR 작성자에게 DM 전송하는 자동화가 안됐습니다.
slack api로 요청하여 slack bot이 DM 보내도록 했지만, missing_post_type 에러가 발생합니다.
추측하기에, slack api가 저희 보내는 데이터 형식을 제대로 이해하지 못한 것 같습니다.
기존에 JSON 데이터를 문자열로 직접 삽입해서 요청보냈으나, 이 경우 특수문자나 줄바꿈이 있으면 JSON 형식이 깨질 수 있다고 합니다.
JSON 데이터를 변수에 저장하여 slack api에게 보내면 안전하게 JSON으로 보낼 수 있다고 합니다.