Skip to content
This repository has been archived by the owner on Nov 29, 2020. It is now read-only.

Fix #79 and #82 Add phone number prefix #124

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

khyper
Copy link

@khyper khyper commented Mar 30, 2019

No description provided.

@khyper khyper changed the title Fix #79 Add phone number prefix Fix #79 and #82 Add phone number prefix Mar 30, 2019
Copy link
Member

@aniri aniri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the country code picker is not vertically aligned the same as the phone number. could you try to align them?

@@ -12,6 +12,7 @@
<string name="hint_time">hh:mm</string>
<string name="empty" />
<string name="error_empty_credentials">Introduceți numărul de telefon şi codul primit.</string>
<string name="error_invalid_phone_number">Numarul de telefon nu este valid.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use diacritics

@aniri
Copy link
Member

aniri commented Apr 1, 2019

@RaduCStefanescu @bvizureanu we will have to check with the back-end to see if we can support also country code for phone numbers. also we have to agree on the accepted phone number format 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants