Feedback

[github-classroom]

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers

Use this PR to leave feedback. Here are some tips:

• Click the Files changed tab to see all of the changes pushed to main since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.
• Click the Commits tab to see the commits pushed to main. Click a commit to see specific changes.
• If you turned on autograding, then click the Checks tab to see the results.
• This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below.
  For more information about this pull request, read “Leaving assignment feedback in GitHub”.

Subscribed: @celsodiaz

[andresnb]

Rails - Week 5 - Extended Project - Tweetable

This rubic breaks the project into several key objectives.
Each one of the goals is scored with the scales listed in the table below.

SKILL	0	1	2	3	4	5
Dev Skills	Not applied	Barely applied	Somewhat applied	Decently applied	Mostly applied	Correctly applied
User Stories	Not applied	Applied but with glitches	Correctly applied
Critical User Stories	Not applied	Applied but not working	Applied but with glitches	Correctly applied
Non Critical Features	Not applied	Applied

To pass, the student needs at least 56
(total of 80 points + 7 bonus points)

STUDENT: CELSO DIAZ CHINCHAY DIAZ
RESULT: APROVED

Total	63
Dev skills	15
User stories	46
Bonus stories	2

DETAILS

Dev Skills	Max Score	Your Score
Deliver in time (June 24)	5	1
Keep your code DRY. Rubucop eabled	5	5
Use Git Flow Accordingly (kanban board / multiple git branches / issues report / pull requests)	5	4
Commits are well-written and communicates clearly what the coder did	5	5
TOTAL	20	15

User stories	Max Score	Your Score
User is a model that has many Tweets	2	2
User could like many Tweets	2	2
Tweet is a model, belongs to a User	2	2
A Tweet could be liked by many Users	2	2
A Tweet could be a reply to another Tweet	2	2
A Tweet could have many replies	2	2
Like is a model, belongs to a Tweet and a User	2	2
User validates email, username, name and password	1	1
password should be at least 6 characters long	1	1
If the user doesn't provide an avatar image, a default avatar image should be used	1	1
For a user, role could be 0 → 'member' or 1 → 'admin'. By default, the role is 'member'	1	1
Tweet validates body and replies_count and likes_count starts at 0 by default	1	1
Replied_to is not required but it should be a valid Tweet id	1	1
The Like model has user_id and tweet_id and should be a unique combination	1	1
A visitor can read a list of Tweets	3	0
A visitor can read a list of replies for a Tweet	3	0
A visitor can sign in or sign up	3	3
A member can create their own Tweets	3	3
A member can edit their own Tweets	3	3
A member can destroy their own Tweets	3	2
A member can create their own Likes	3	3
A member can destroy their own Likes	2	0
A member can edit its profile	3	2
If I try to execute a non permited action for my current role I should be blocked	3	3
Create a end-point to show all the Tweets (API interface)	2	2
Create another end-point to show a Tweet with tweets associations (API interface)	2	0
I can automatically seed the db	3	3
CSS styling respects minimum requirements of fonts, colors and layouts	3	1
TOTAL	60	46

Bonus stories	Max Score	Your Score
Private endpoints	3	0
I can run a set of tests	2	0
Authentication with GitHub	2	2
TOTAL	7	2

NOTES

• Los nombres de las ramas pueden ser mas detallados
• No se puede quitar los likes.
• Los visitantes no pueden ver tweets