Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kmm combined chart #123

Open
wants to merge 8 commits into
base: kmm-main
Choose a base branch
from
Open

Kmm combined chart #123

wants to merge 8 commits into from

Conversation

AkYML
Copy link
Contributor

@AkYML AkYML commented Jul 11, 2023

No description provided.

@AkYML AkYML requested review from dkk009 and kikoso as code owners July 11, 2023 10:06
@AkYML
Copy link
Contributor Author

AkYML commented Jul 11, 2023

Simulator Screenshot - iPhone 14 - 2023-07-11 at 17 10 04

@AkYML AkYML changed the title WIP: Kmm combined chart Kmm combined chart Jul 12, 2023
dkk009
dkk009 reviewed Jul 12, 2023
View reviewed changes
KMMYCharts/src/commonMain/kotlin/co/yml/kmm/charts/ui/linechart/LineChart.kt Outdated
@@ -101,7 +101,7 @@ internal fun LineChart(modifier: Modifier, lineChartData: LineChartData) {
xMax,
xMin,
xOffset,
paddingRight.toPx(),
paddingRight.toSp().toPx(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeangi Do we need sp conversion here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No @dkk009 its a mistake, i've updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkk009 dkk009 dkk009 left review comments

@kikoso kikoso Awaiting requested review from kikoso

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkYML @dkk009 @anup350