Advanced Cubic Bezier algorithm for prettier line charts #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red import (kotlin.math.pow)
Optimised slope calculation by using a holding FloatArray to avoid recalculation, and using null is also avoided by this
Further optimised slopes array by removing redundant entry of last value
Optimised in-between slope calculation by replacing 'pow' with 'sqrt' and self multiplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Modified LineChart to use the Advanced Cubic Bezier algorithm for line smoothening as given at https://medium.com/mobile-app-development-publication/making-graph-plotting-function-in-jetpack-compose-95c80ee6fc7f
💡 Motivation and Context
The default line chart has a 'staggered' look which is not found in libs like chart.js or SwiftUI charts, so I searched for ways to improve the smoothening algorithm and found the mentioned article, and tried it out.
💚 How did you test it?
Using the library with the modified file in an Android project as module dependency and tested both on emulator and device
📝 Checklist
📸 Screenshots / GIFs
Basic Cubic Bezier
Advance Cubic Bezier
Validation
Run the sample app and check the difference in the Line Charts
Risks
It is computationally more expensive than the basic cubic Bezier