[WIP] Fix character encoding when EciMode is specified #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
changed the title
This was referenced May 9, 2024
gfoidl
reviewed
May 22, 2024
| var bytes = Encoding.GetEncoding("ISO-8859-1").GetBytes(input); | ||
| var result = Encoding.GetEncoding("ISO-8859-1").GetString(bytes); | ||
| return String.Equals(input, result); | ||
| return encoding == EncodingMode.Byte ? (codedText.Length / 8) : plainText.Length; |
There was a problem hiding this comment.
Suggested change
| return encoding == EncodingMode.Byte ? (codedText.Length / 8) : plainText.Length; | |
| return encoding == EncodingMode.Byte ? (int)((uint)codedText.Length / 8) : plainText.Length; |
do we care about such things here too?
There was a problem hiding this comment.
Yes; we certainly can optimize this PR also.
I need to come back to this PR; but for now I was leaving it alone until I'm finished with performance PRs.
|
Hi @Shane32 , since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR. Would you prefer me to merge it before the archival, or should I close it instead? Thanks again for your effort and contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #513