Skip to content

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Apr 13, 2025

Prerequisites (to reduce diff):

Status:

  • All generated micro QR codes are scannable
  • Most QR codes match the output of the segno python library
  • Need to add tests and validate combinations of lengths, character types, etc

Side notes:

  • ASCII small generator has x/y swapped and prints inverted compared to regular ASCII generator
  • The segno python library does not apply padding properly so micro QR codes consisting mostly of padding don't match

@Shane32
Copy link
Contributor Author

Shane32 commented Apr 14, 2025

M2 codes will generate correctly now

@Shane32
Copy link
Contributor Author

Shane32 commented Apr 16, 2025

Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now.

@Shane32 Shane32 marked this pull request as ready for review April 19, 2025 15:30
@Shane32
Copy link
Contributor Author

Shane32 commented Apr 19, 2025

This implementation is complete. I might add some more tests but everything is working.

@gfoidl
Copy link
Contributor

gfoidl commented Apr 23, 2025

I'm looking forward to review the PR, but after #590 got merged so I can focus on the new stuff.

@Shane32 👍🏻 for your work

@codebude
Copy link
Owner

codebude commented Jun 2, 2025

@gfoidl #590 is merged now.

@gfoidl
Copy link
Contributor

gfoidl commented Jun 2, 2025

@Shane32 please merge the master-branch in your micro-branch, so that the latest changes are in and the diff becomes smaller for review 😉. IIRC GitHub doesn't do that automatically.

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 2, 2025

I've merged it, but it looks like the CI scripts are failing again...

Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestion to the code.
For the logic about micro QR code I can't tell very much, here I trust @Shane32.

Shane32 and others added 5 commits June 2, 2025 16:46
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
@Shane32
Copy link
Contributor Author

Shane32 commented Jun 2, 2025

Thanks @gfoidl !

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 13, 2025

CI scripts have been fixed - @codebude can you review?

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 16, 2025

Hey @codebude do you have a little time to review this PR?

@Shane32
Copy link
Contributor Author

Shane32 commented Aug 17, 2025

@codebude Any update here?

@Shane32
Copy link
Contributor Author

Shane32 commented Sep 1, 2025

@codebude Think we could merge this in?

@codebude
Copy link
Owner

Hi @Shane32 ,

since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR.

Would you prefer me to merge it before the archival, or should I close it instead?
Please let me know what you think – I want to handle your contribution in the way that feels most appropriate to you.

Thanks again for your effort and contribution!

@Shane32
Copy link
Contributor Author

Shane32 commented Sep 28, 2025

@codebude As you know, I've put in a considerable amount of effort recently with refactoring, xml documentation, speed improvements, and most recently adding support of Micro QR codes. As an alternative to archiving the repository, I was wondering if you'd consider transferring the project to me to continue further maintenance and development.

Please review my profile; you will find I'm currently the primary maintainer of GraphQL.NET which presently has a total of 57M downloads, as well as a collaborator of linq2db. I also have personally created and/or maintain a number of other open source projects as seen here:

I have a strong commitment to high-quality, open-source (MIT licensed) code, wide technology support, community approval of changes, and quick response time to support requests.

While I could fork the repository and publish it under a new name, I feel that it would be in the best interest of users if I could continue supporting the project directly. If you’re interested, please let me know.

Thank you again for all the time and effort you’ve put into creating and maintaining this package — it has been a valuable resource for the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants