-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Micro QR code support #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
M2 codes will generate correctly now |
Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now. |
Co-authored-by: Günther Foidl <gue@korporal.at>
This implementation is complete. I might add some more tests but everything is working. |
@Shane32 please merge the master-branch in your micro-branch, so that the latest changes are in and the diff becomes smaller for review 😉. IIRC GitHub doesn't do that automatically. |
I've merged it, but it looks like the CI scripts are failing again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestion to the code.
For the logic about micro QR code I can't tell very much, here I trust @Shane32.
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Thanks @gfoidl ! |
CI scripts have been fixed - @codebude can you review? |
Hey @codebude do you have a little time to review this PR? |
@codebude Any update here? |
@codebude Think we could merge this in? |
Hi @Shane32 , since QRCoder will reach its end of life and the repository will be archived on November 1st, 2025, I’d like to clarify how to proceed with this PR. Would you prefer me to merge it before the archival, or should I close it instead? Thanks again for your effort and contribution! |
@codebude As you know, I've put in a considerable amount of effort recently with refactoring, xml documentation, speed improvements, and most recently adding support of Micro QR codes. As an alternative to archiving the repository, I was wondering if you'd consider transferring the project to me to continue further maintenance and development. Please review my profile; you will find I'm currently the primary maintainer of GraphQL.NET which presently has a total of 57M downloads, as well as a collaborator of linq2db. I also have personally created and/or maintain a number of other open source projects as seen here: I have a strong commitment to high-quality, open-source (MIT licensed) code, wide technology support, community approval of changes, and quick response time to support requests. While I could fork the repository and publish it under a new name, I feel that it would be in the best interest of users if I could continue supporting the project directly. If you’re interested, please let me know. Thank you again for all the time and effort you’ve put into creating and maintaining this package — it has been a valuable resource for the community. |
Prerequisites (to reduce diff):
Status:
Side notes: