Skip to content

Commit

Permalink
Add comment about errors on success
Browse files Browse the repository at this point in the history
  • Loading branch information
codeconscious committed Oct 20, 2024
1 parent ea2ae50 commit f8f2292
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/CCVTAC.Console/ExternalTools/Runner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ private static bool IsSuccessExitCode(HashSet<int> otherSuccessExitCodes, int ex

var trimmedErrors = errors.TrimTerminalLineBreak();
return IsSuccessExitCode(otherSuccessExitCodes ?? [], process.ExitCode)
? Result.Ok((process.ExitCode, trimmedErrors))
? Result.Ok((process.ExitCode, trimmedErrors)) // Errors will be considered warnings.
: Result.Fail($"[{settings.Program.Name}] Exit code {process.ExitCode}: {trimmedErrors}.");
}
}

0 comments on commit f8f2292

Please sign in to comment.