Conversation
- Updated `publish.yml` and `ci.yml` to use `working-directory` for subpackage steps. - Switched to `bun x tsup` for builds to ensure binaries are found regardless of environment PATH. - Improved dependency installation flow for monorepo-style subpackages. - Added explicit build-step logging for better pipeline debugging. Co-authored-by: codedbytahir <200578194+codedbytahir@users.noreply.github.com>
- Added `repository` field with `url` and `directory` to `packages/create-motionforge/package.json`. - Added `directory` field to the `repository` in `packages/motionforge/package.json`. - Added `repository` field to the root `package.json`. - Standardized the repository URL format to `git+https://github.com/...` for compatibility with sigstore/provenance verification. Co-authored-by: codedbytahir <200578194+codedbytahir@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughRepository metadata is standardized across the project by adding or updating the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/publish.yml (1)
36-40:⚠️ Potential issue | 🟠 MajorAvoid direct secret interpolation in shell scripts — use an environment variable instead.
${{ secrets.NPM_TOKEN }}is interpolated directly into the shell script before execution. If the secret ever contains shell metacharacters (e.g., quotes, backticks), the script could break or be exploited via script injection. Use an env variable to safely pass the secret into the shell context.🛡️ Proposed fix
- name: Verify NPM Token + env: + NPM_TOKEN: ${{ secrets.NPM_TOKEN }} run: | - if [ -z "${{ secrets.NPM_TOKEN }}" ]; then + if [ -z "$NPM_TOKEN" ]; then echo "::error::NPM_TOKEN is missing. Please add it to your GitHub Repository Secrets." exit 1 fi
Summary by CodeRabbit