⚡️ Speed up method Representation.__str__
by 30%
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 30% (0.30x) speedup for
Representation.__str__
inpydantic/_internal/_repr.py
⏱️ Runtime :
1.46 microsecond
→1.12 microsecond
(best of443
runs)📝 Explanation and details
To enhance the performance of the provided
Representation
class, we aim to optimize the comprehension and concatenation in the__repr_str__
method, as well as ensuring efficient attribute access. Here's the rewritten version.Explanation of changes.
args
: By introducing a local variableargs
in__repr_str__
, we avoid multiple function calls toself.__repr_args__()
, improving readability and potentially performance.parts
using a loop instead of a generator expression to avoid the overhead of multiple function calls.a
isNone
and append the appropriate representation to theparts
list. This is more efficient than inline conditions within the join operation.The above rewrite should be more efficient due to reduced redundant computations and function calls, while ensuring the same functionality and outputs as the original program.
✅ Correctness verification report:
🌀 Generated Regression Tests Details
📢 Feedback on this optimization?