⚡️ Speed up blend_rgb()
by 18% in rich/color.py
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
blend_rgb()
inrich/color.py
📈 Performance improved by
18%
(0.18x
faster)⏱️ Runtime went down from
129 microseconds
to110 microseconds
Explanation and details
Sure, let's optimize the code using some simple improvements while maintaining the same functionality.
ColorTriplet
fromrich.color_triplet
is removed.ColorTriplet
instance is done usingself.red
,self.green
, andself.blue
for properties.Here's the optimized code.
Explanation.
ColorTriplet
fromrich.color_triplet
since we are defining it locally.self.red
,self.green
, andself.blue
inside the property methods without destructuring theself
tuple, which reduces the number of operations.These changes should make the class and the blend function slightly faster by reducing unnecessary operations and making direct property accesses.
Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 17 Passed − ⚙️ Existing Unit Tests
(click to show existing tests)
✅ 25 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests