Open
Conversation
Fixed typo in migration comment for trees table. Modified existing columns to match new export format. :( Modified import script to match new export format.
HelenBielawa
reviewed
Jan 5, 2026
Contributor
HelenBielawa
left a comment
HelenBielawa
left a comment
There was a problem hiding this comment.
-
Durchmesser ist ja der doppelte Radius, also nicht derselbe Wert. Scheinbar gibt's in den Daten beides (und scheinbar war im alten Import der Radius und nun haben wir den Durchmesser). Daher Änderungsvorschlag: Neue Spalten für Durchmesser anlegen, Radius leer lassen -> dann gerne mergen.
-
Optionaler Vorschlag: das Skript würde sicher stabiler, wenn überall fallback Werte eingetragen wären, wie du sie jetzt bei einigen Fällen ergänzt hast.
Contributor
|
Für das planting_year sollte None statt 0 als fallback gewählt werden Entscheidung: Wir vertagen den Merge, bis wir ein Interface mit dem Umweltbetrieb abgestimmt haben, um künftige Datenank-Struktur-Änderungen zu vermeiden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added columns for planting year and object numbers.
Fixed typo in migration comment for trees table.
Modified existing columns to match new export format. :(
Modified import script to match new export format.