Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explanation of proposed CI YAML file #55

Merged
merged 3 commits into from
Oct 9, 2023
Merged

explanation of proposed CI YAML file #55

merged 3 commits into from
Oct 9, 2023

Conversation

ProsperousHeart
Copy link
Member

@ProsperousHeart ProsperousHeart commented Jun 10, 2023 •
edited
Loading

explanation of proposed CI YAML file - discussing with CI YAML creator about a couple of things, but wanted to be sure to put this into a draft PR for others to be able to review

resolves #56

@ProsperousHeart ProsperousHeart added enhancement Not a requirement - enhances or improves project documentation Update to documentation labels Jun 10, 2023
@ProsperousHeart ProsperousHeart self-assigned this Jun 10, 2023
@ProsperousHeart ProsperousHeart mentioned this pull request Jun 10, 2023
Closed
@ProsperousHeart ProsperousHeart linked an issue Jun 10, 2023 that may be closed by this pull request
DOC UPDATE: Explanation of CI File #56
Closed
@ProsperousHeart ProsperousHeart mentioned this pull request Jun 11, 2023
Closed
@ProsperousHeart
Copy link
Member Author

need to add in info from this comment

@ProsperousHeart ProsperousHeart marked this pull request as ready for review October 9, 2023 00:55
RobinHerzig
RobinHerzig reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@RobinHerzig RobinHerzig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there's a small typo on line 7:

"checking code for style errors or erros in general"

ProsperousHeart
ProsperousHeart commented Oct 9, 2023
View reviewed changes
docs/CI_Explainer.md Outdated Show resolved Hide resolved
RobinHerzig
RobinHerzig approved these changes Oct 9, 2023
View reviewed changes
docs/CI_Explainer.md Outdated Show resolved Hide resolved
@ProsperousHeart ProsperousHeart merged commit 29a8bc0 into codefordallas:v1-mvp Oct 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinHerzig RobinHerzig RobinHerzig approved these changes

Assignees

@ProsperousHeart ProsperousHeart

Labels
documentation Update to documentation enhancement Not a requirement - enhances or improves project
Projects
Site Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC UPDATE: Explanation of CI File
2 participants
@ProsperousHeart @RobinHerzig