Issue58 doc4 formatting add

[ProsperousHeart]

resolves #58 related to #57

[RobinHerzig]

Would it be helpful to add the commands used to run these packages? I.e., npm run lint and npm run format.

[ProsperousHeart]

Would it be helpful to add the commands used to run these packages? I.e., npm run lint and npm run format.

I think so. I thought I put the formatting in though. Do you think it would be more clear to be explicit about each package in our package.json file?

[RobinHerzig]

I don't think every package needs to be explicitly explained, just those that affect the upload process. For example, I'm assuming testing and formatting will be part of the standard now.

[ProsperousHeart]

I don't think every package needs to be explicitly explained, just those that affect the upload process. For example, I'm assuming testing and formatting will be part of the standard now.

Got it. What about when we inform people that there's an update to remind them (if the package.json file was updated) to run npm install again?

Also - a few more changes have been done since you reviewed @RobinHerzig as there were updates to #57

[RobinHerzig]

The changes look good. I like the idea of telling people to run npm install again after updating.

Do we have a quick reference for writing code and creating pull requests? If not, I can help with that. I just say that because, if people are meant to run npm run lint and npm run format before committing code, then it'd be nice to have it a guide to follow when working in the terminal.

[ProsperousHeart]

The changes look good. I like the idea of telling people to run npm install again after updating.

Do we have a quick reference for writing code and creating pull requests? If not, I can help with that. I just say that because, if people are meant to run npm run lint and npm run format before committing code, then it'd be nice to have it a guide to follow when working in the terminal.

We do not, though this idea is part of these:

• Create Repo Template for PRs #30
• create template for issues #31
• Create Guidelines For Contribution #32
• Update Contribution File #51

One of the other members was going to take a stab at it from a prior meeting we had, but I don't know if they ever did anything with their notes.

[ProsperousHeart]

will confirm with @jhoover4 once #49 is complete that this accurately reflects his code

[jhoover4]

I think preferred is that they just run npm install instead of installing things individually. Unless we're just trying to explain the concept here

[ProsperousHeart]

this was for concept yes, but we definitely don't want to cause confusion if we can avoid it - I'll look at updating this shortly

[jhoover4]

This should be done! I chose to go with just using the eslint extension here: https://github.com/codefordallas/codefordallas.github.io/blob/v1-mvp/.eslintrc.js#L2

[jhoover4]

This is great! Thanks for adding this Kassandra :)

[jhoover4]

The changes look good. I like the idea of telling people to run npm install again after updating.
Do we have a quick reference for writing code and creating pull requests? If not, I can help with that. I just say that because, if people are meant to run npm run lint and npm run format before committing code, then it'd be nice to have it a guide to follow when working in the terminal.

We do not, though this idea is part of these:

* [Create Repo Template for PRs #30](https://github.com/codefordallas/codefordallas.github.io/issues/30)

* [create template for issues #31](https://github.com/codefordallas/codefordallas.github.io/issues/31)

* [Create Guidelines For Contribution #32](https://github.com/codefordallas/codefordallas.github.io/issues/32)

* [Update Contribution File #51](https://github.com/codefordallas/codefordallas.github.io/issues/51)

One of the other members was going to take a stab at it from a prior meeting we had, but I don't know if they ever did anything with their notes.

I can take a go at the PR template at least

[ProsperousHeart]

This is great! Thanks for adding this Kassandra :)

Fantastic! Thanks for taking a gander.

The changes look good. I like the idea of telling people to run npm install again after updating.
Do we have a quick reference for writing code and creating pull requests? If not, I can help with that. I just say that because, if people are meant to run npm run lint and npm run format before committing code, then it'd be nice to have it a guide to follow when working in the terminal.

We do not, though this idea is part of these:

* [Create Repo Template for PRs #30](https://github.com/codefordallas/codefordallas.github.io/issues/30)

* [create template for issues #31](https://github.com/codefordallas/codefordallas.github.io/issues/31)

* [Create Guidelines For Contribution #32](https://github.com/codefordallas/codefordallas.github.io/issues/32)

* [Update Contribution File #51](https://github.com/codefordallas/codefordallas.github.io/issues/51)

One of the other members was going to take a stab at it from a prior meeting we had, but I don't know if they ever did anything with their notes.

I can take a go at the PR template at least

If you have the time and want to take a stab at it that would be great! Thank you @jhoover4