Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding names to routes #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding names to routes #111

wants to merge 1 commit into from

Conversation

AlanPeters
Copy link
Contributor

Naming routes adds a function in the cwbn/routes ns which you can use to
get the default path or build a path based on rules for the route.

Naming routes adds a function in the cwbn/routes ns which you can use to
get the default path or build a path based on rules for the route.
Copy link
Member

@dviramontes dviramontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks @AlanPeters !

@dviramontes
Copy link
Member

@AlanPeters is this still relevant ?

@AlanPeters
Copy link
Contributor Author

Yes, it is more of a minor enhancement but I will resolve conflicts tonight

@dviramontes
Copy link
Member

Gotcha, sounds good!

@dviramontes
Copy link
Member

@AlanPeters wondering if we can still rebase this ? - i was reading about named routes and i think they make a lot of sense. Lmk if you need any help with this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants