Skip to content

Conversation

zxqj
Copy link
Collaborator

@zxqj zxqj commented Feb 2, 2019

This makes the changes addressed in Issues #461 and #462.

Note. The menu I implemented for filtering by tags looks slightly different than the one in #462. The number of tags made the menu extend very far down. I thought it looked better truncated at a certain point, which necessitated the scroll bar. I then added the slight color difference to distinguish the inside and outside of the scrollable area. Let me know what you think.

Patrick Branch added 2 commits January 22, 2019 13:31
…rger dialog which drops down over the center and whose visibility can be toggled. Added spot for large image with accompanying text to be displayed at the top of the page on the branches and filtered activities views.
@zxqj zxqj requested a review from eemshi February 2, 2019 11:46
@dviramontes
Copy link
Member

screen shot 2019-02-13 at 11 34 15 pm

looks like mobile experience for this feature is hindered by the size of the selection box. Its possible that a media query could solve this issue or it might require some rethinking.

tagging @eemshi to see what she thinks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants