Skip to content

refactor: compare $db->connID to false #9891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 1 commit into from
Jan 18, 2026
+3 −12
Merged

refactor: compare $db->connID to false #9891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function load(array $params = [], string $alias = '')
*/
public function loadForge(ConnectionInterface $db): Forge
{
if (! $db->connID) {
if ($db->connID === false) {
$db->initialize();
}

Expand All @@ -84,7 +84,7 @@ public function loadForge(ConnectionInterface $db): Forge
*/
public function loadUtils(ConnectionInterface $db): BaseUtils
{
if (! $db->connID) {
if ($db->connID === false) {
$db->initialize();
}

Expand Down
8 changes: 0 additions & 8 deletions utils/phpstan-baseline/booleanNot.exprNotBoolean.neon
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
# total 2168 errors
# total 2166 errors

includes:
- argument.type.neon
- arguments.count.neon
- assign.propertyType.neon
- booleanNot.exprNotBoolean.neon
- codeigniter.getReassignArray.neon
- codeigniter.modelArgumentType.neon
- codeigniter.superglobalAccess.neon
Expand Down
Loading