[신휘철] Sprint11 #332
Merged
[신휘철] Sprint11 #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Dec 9, 2024
Comment on lines
+17
to
+19
| {login && signup && <Header />} | ||
| <Component {...pageProps} /> | ||
| <Footer /> | ||
| {login && signup && <Footer />} |
Collaborator
There was a problem hiding this comment.
저번에 말씀드렸던 getLayout 기능을 활용해서 페이지 별로 Layout을 지정해보시는 것도 좋을 것 같습니다.
| password: "", | ||
| }); | ||
| const [isPasswordHidden, setIsPasswordHidden] = useState(false); | ||
| const [emailErrorMessage, setEmailErrorMessage] = useState(""); |
Collaborator
There was a problem hiding this comment.
에러가 없는 경우에 빈 문자열 보다는 null 같은 값으로 명시적으로 표시해주시는 것도 좋을 것 같습니다.
Comment on lines
+44
to
+55
| setLoginInfo((prevLoginInfo) => ({ | ||
| ...prevLoginInfo, | ||
| [name]: value, | ||
| })); | ||
|
|
||
| if (name === "password") { | ||
| if (loginInfo.password.length < 7) { | ||
| setPasswordErrorMessage("비밀번호를 8자 이상 입력해 주세요."); | ||
| } else { | ||
| setPasswordErrorMessage(""); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
password 상태가 반영된 후에 에러가 뜰 것 같아서 에러를 먼저 처리해주시고 상태가 반영되게 하는건 어떨까요?
| <div className="inner"> | ||
| <h1> | ||
| <Link className="logo" href={"/"}> | ||
| <Image src={Logo} alt="logo" /> |
Collaborator
There was a problem hiding this comment.
next/image는 width / height나 fill이 없으면 잘 동작하지 않을텐데 괜찮나요?
Comment on lines
+80
to
+82
| const handlePasswordToggleClick = () => { | ||
| setIsPasswordHidden(!isPasswordHidden); | ||
| }; |
Collaborator
There was a problem hiding this comment.
토글하는 로직이 많은 것 같은데 훅으로 만들어보셔도 좋을 것 같습니다.
| const router = useRouter(); | ||
| const [login, setLogin] = useState(false); | ||
| useEffect(() => { | ||
| if (localStorage.getItem("accessToken")) { |
Collaborator
There was a problem hiding this comment.
localStorage에서 accessToken을 가져와서 로그인 시켜버린다면, 악성 유저가 accessToken을 강제로 넣었을때도 로그인 됐다고 뜰 것 같습니다. 다른 방법도 생각해보시면 좋을 것 같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
체크리스트[기본]
회원가입 페이지
로그인 페이지
메인
스크린샷
스크린샷 대신 URL로 대체하겠습니다.
배포 URL: https://hwiiron.netlify.app/
멘토님에게