[장수경] sprint11 #333
Merged
[장수경] sprint11 #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baeggmin
reviewed
Dec 10, 2024
Collaborator
There was a problem hiding this comment.
getServersideProps 를 완전히 제거하셨군요~?
이제 board 페이지에서는 에러 안 발생하나요??
baeggmin
approved these changes
Dec 10, 2024
Collaborator
baeggmin
left a comment
baeggmin
left a comment
There was a problem hiding this comment.
고생하셨습니다~👏
MarketPage 에서 발생한다는 404 에러는 accesstoken 때문 아닐까요?
먼저 로그인 기능을 구현하시고 accesstoken 을 받아 request header 에 넣어주시면 해결될 듯 합니당
| // const query = new URLSearchParams().toString(); // 빈 쿼리 문자열을 생성 | ||
| const query = `limit=${limit}`; | ||
| // const query = `limit=${limit}`; | ||
| const query = new URLSearchParams(params).toString(); |
Collaborator
There was a problem hiding this comment.
URLSearchParams 를 잘 활용해주셨습니다! 👍
| const nextConfig = { | ||
| reactStrictMode: true, | ||
| images: { | ||
| domains: [ |
Collaborator
There was a problem hiding this comment.
외부에서 이미지를 가져올 일이 있었나요..?
| const [content, setContent] = useState(""); | ||
|
|
||
| // 이미지 제외 모든 input에 값이 입력 | ||
| const isSubmit = !title.trim() || !content.trim(); |
Collaborator
There was a problem hiding this comment.
사소한 코멘트지만 isDisabled 가 더 적절할 것 같습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게