Open
Conversation
Collaborator
|
커밋 메세지들이 아주 깔끔하네요 👍 |
joonfluence
reviewed
Feb 7, 2026
.idea/.gitignore
Outdated
joonfluence
reviewed
Feb 7, 2026
Collaborator
There was a problem hiding this comment.
DTO 같이 불변성이 보장되어야 하는 클래스의 경우 class -> record 로 선언해서 사용합니다!
joonfluence
reviewed
Feb 7, 2026
Collaborator
There was a problem hiding this comment.
이 클래스 외에도 엔티티 계층 요소들은 ~ Entity로 명시해주는 편이 좋습니다~!
joonfluence
reviewed
Feb 7, 2026
Comment on lines
+52
to
+53
| binaryContentRepository.save(binaryContent); | ||
| return binaryContent.getId(); |
Collaborator
There was a problem hiding this comment.
부수효과 없이 작성하기 위해 데이터 수정/생성 작업은 외부로 빼서 for-each 에서 최종적으로 수행하는 편이 좋습니다!
joonfluence
reviewed
Feb 7, 2026
Comment on lines
+70
to
+73
| // 사용자별 상태 조회 | ||
| UserStatus userStatus = userStatusRepository.findByUserId(user.getId()); | ||
| return toResponseDTO(user, userStatus); | ||
| }) |
joonfluence
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
Spring 핵심 개념 이해하기
추가
심화
주요 변경사항
스크린샷
멘토에게