[강지원] sprint3#54
Open
jikang24 wants to merge 17 commits intocodeit-bootcamp-spring:강지원from
Hidden character warning
The head ref may contain hidden characters: "\uac15\uc9c0\uc6d0-spring_misson_3"
Open
Conversation
added 17 commits
January 9, 2026 14:42
joonfluence
reviewed
Feb 8, 2026
| package com.sprint.mission.discodeit.DTO; | ||
|
|
||
|
|
||
| public class BinaryContentDTO { |
joonfluence
reviewed
Feb 8, 2026
| import java.util.UUID; | ||
|
|
||
| @Getter | ||
| public class Channel implements Serializable { |
There was a problem hiding this comment.
이 클래스 외에도 엔티티 계층 요소들은 ~ Entity로 명시해주는 편이 좋습니다~!
joonfluence
reviewed
Feb 8, 2026
|
|
||
| return channels.stream() | ||
| .map(channel -> { | ||
| ReadStatus readStatus = readStatusRepository.findByUserIdAndChannelId(channel.getUserId(), channel.getChannelId()) |
There was a problem hiding this comment.
조회 로직 바깥으로 변경 및 IN 절로 한번에 조회해와서 Map으로 조합해서 처리해보시죠
- 부수효과
- N+1 문제 발생
joonfluence
reviewed
Feb 8, 2026
Comment on lines
+36
to
+41
| .findFirst() | ||
| .map(user -> new UserServiceResponseDTO.FindUserId( | ||
| user.getId(), | ||
| user.isOnline(), | ||
| user.getUpdatedAt() | ||
|
|
joonfluence
approved these changes
Feb 8, 2026
joonfluence
reviewed
Feb 8, 2026
Comment on lines
+1
to
+3
| spring: | ||
| application: | ||
| name: discodeit No newline at end of file |
There was a problem hiding this comment.
이거 @ConditionalOnProperty 설정이 빠져 있네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
추가 요구사항
: JCFRepository 구현체는 구현하지 못했습니다.
심화
주요 변경사항
스크린샷
멘토에게
*Spring 핵심 개념 이해하기
기존 JavaApplication에서는
UserService userService = new UserService(...);
User user = setupUser(userService);
위와 같이 새롭게 생성자 메서드로 객체 생성도 내가 하고 정보전달도 내가 하고
생명주기까지 전부 내가 관리해야했다.
하지만 DiscodeitApplication에서는
Spring을 통해 IoC Container가 각 구현체로부터 Dependency Injection(DI)를 주입받고
Bean을 자동으로 생성, 등록, 소멸까지 라이프사이클을 관리하므로 초기화방식에서 차이가 난다.