Open
Conversation
P1su
approved these changes
Jul 9, 2025
Member
P1su
left a comment
There was a problem hiding this comment.
리뷰가 늦어져 죄송합니다..!
컨테이너마다 간격이 전부 다르던데 하나 하나 맞추느라 고생하셨습니다.
버킷리스트 정렬하는 방식도 좋은 것 같아요!
Comment on lines
29
to
+39
| export const TopRightPixel = styled.div` | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| width: 1.7rem; | ||
| height: 1.2rem; | ||
| width: 2.2rem; | ||
| height: 0.6rem; | ||
| background-color: ${({ theme }) => theme.colors.black}; | ||
| &::after { | ||
| content: ''; | ||
| position: absolute; | ||
| width: 1rem; | ||
| height: 0.6rem; | ||
| background-color: ${({ theme }) => theme.colors.blue}; | ||
| left: 0; | ||
| bottom: 0; | ||
| } | ||
| box-shadow: | ||
| 0.5rem 0.5rem 0 0 ${({ theme }) => theme.colors.black}, | ||
| 1.1rem 1.1rem 0 0 ${({ theme }) => theme.colors.black}, | ||
| 1.6rem 1.6rem 0 0 ${({ theme }) => theme.colors.black}; |
Member
There was a problem hiding this comment.
나머지 모서리 부분들도 기본적인 틀은 동일하고 box-shadow 부분만 코드가 다른데
const PixelBoxBase = styled.div`
position: absolute;
width: 2.2rem;
height: 0.6rem;
background-color: ${({ theme }) => theme.colors.black};
`;
위와 같이 base 스타일을 설정해주고
export const TopRightPixel = styled(PixelBoxBase)`
top: 0;
right: 0;
box-shadow:
0.5rem 0.5rem 0 0 ${({ theme }) => theme.colors.black},
1.1rem 1.1rem 0 0 ${({ theme }) => theme.colors.black},
1.6rem 1.6rem 0 0 ${({ theme }) => theme.colors.black};
`;
모서리 부분들은 position 값과 box-shadow값만 설정해주면 추후에 수정할 때 훨씬 간편할 것 같아요 !
| <S.ProgressValue $value={value} /> | ||
| <S.ProgressBarTopCorners /> | ||
| <S.ProgressBarBottomCorners /> | ||
| {Array.from({ length: Math.ceil(value / 10) }, (_, i) => ( |
Member
There was a problem hiding this comment.
사소한 부분이긴 한데 floor를 통해서 버림으로 표현하는 것은 어떨까요?
예를 들어 현재 달성률이 33%인 경우 4칸으로 표시되는데, 아직 40%에 도달하지 않았으므로 3칸으로 표현하는 것이 조금 더 자연스러울 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
🪄작업 내용
IcGaugeBar,IcTitleBox아이콘 추가💖리뷰 요청사항
모멘트 생성 로직이 리팩토링 되었기 때문에 모멘트 페이지에 작성되었던 임시 에러처리 코드는 삭제하였습니다.
폴더 구조는 따로 이슈 생성하여 정리하도록 하겠습니다!