[이태빈] Sprint11 #52
Merged
[이태빈] Sprint11 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-mission-BE into express-이태빈-main
coldplay126
approved these changes
Jun 24, 2025
coldplay126
left a comment
coldplay126
left a comment
There was a problem hiding this comment.
전반적으로 훌륭하게 과제를 완수하셨습니다. TypeScript 마이그레이션이 쉽지 않았을텐데 잘 해내셨어요. 특히 MVC 패턴을 유지하면서 타입 안전성을 확보한 점과, Prisma 타입을 적극적으로 활용한 점이 인상적입니다.
| export type productDto = { | ||
| name: string; | ||
| description: string; | ||
| price: string; |
There was a problem hiding this comment.
가격은 금액이 입력될 것 같은데 숫자가 아닌 문자인 이유가 있을까요?
| }; | ||
|
|
||
| // 상품 상세조회 | ||
| const getProduct = async (userId: User["id"], productId: Product["id"]) => { |
There was a problem hiding this comment.
Prisma에서 생성된 타입을 적극적으로 활용하여 타입 안전성을 확보한 점이 훌륭합니다!
Comment on lines
+1
to
+11
| export class AppError extends Error { | ||
| code?: number; // 선택적 속성으로 변경 | ||
| data?: any; // 에러핸들러에서 사용하는 data 속성도 추가 | ||
|
|
||
| constructor(message: string, code?: number, data?: any) { | ||
| super(message); | ||
| this.code = code; | ||
| this.data = data; | ||
| this.name = "AppError"; | ||
| } | ||
| } |
There was a problem hiding this comment.
기본 Error 클래스를 확장하여 애플리케이션 전용 에러 클래스를 만든 점이 훌륭합니다. 처리의 일관성을 보장하는 좋은 패턴이에요.
coldplay126
merged commit 7e361dd
into
codeit-sprint-fullstack:express-이태빈
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본 요구사항
공통
any타입의 사용은 최소화해 주세요.프론트엔드
백엔드
tsconfig.json파일을 생성하고, 필요한 컴파일러 옵션을 설정해야 합니다. (예:outDir).package.json에 설정해 주세요. (예: 빌드 및 개발 서버 실행 명령어).ts-node와nodemon을 사용하여 개발 환경을 구성합니다.nodemon과 함께ts-node를 사용하여. ts파일이 변경될 때 서버를 자동으로 재시작하도록 설정합니다.declare를 사용하여 타입을 오버라이드하거나 확장합니다.주요 변경사항
스크린샷
멘토에게