[김단이] Sprint11 #58
Merged
[김단이] Sprint11 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| export type SignUpDTO = z.infer<typeof SignUpSchema>; | ||
| export type SignInDTO = z.infer<typeof SignInSchema>; No newline at end of file |
| userId: number; | ||
| }; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
generic 활용 너무 잘 하셨어요. 팀 프로젝트 시 팀원들한테 지식공유 해주시면 더 좋을 것 같아요.
| code?: number; | ||
| }; | ||
| error.code = 403; | ||
| throw error; |
| export async function getArticleById( | ||
| id: number, | ||
| userId?: number | ||
| ): Promise<any | null> { |
Contributor
There was a problem hiding this comment.
다른 코드에서는 generic 등 잘 쓰셨는데 any를 지양하는 방법 한번 고민해보세요!
| import multer from "multer"; | ||
| import multer, { StorageEngine } from "multer"; | ||
| import path from "path"; | ||
| import fs from "fs"; |
Contributor
There was a problem hiding this comment.
fs/promise를 안 쓰시고 동기를 쓰신 이유가 궁금합니다!
loquemedalagana
merged commit ded7b1e
into
codeit-sprint-fullstack:express-김단이
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏁 스프린트 미션 11 - 시안 확인
🔗 참고 링크
스프린트 미션 11 Figma 디자인 확인하러 바로가기
✅ 요구사항 체크리스트
기본 요구사항
공통
프론트엔드
백엔드
📸 스크린샷
📝 멘토님에게 남길 메시지