[김다은] Sprint9 #203
Open
[김다은] Sprint9 #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokdo2013
approved these changes
May 8, 2025
dokdo2013
left a comment
dokdo2013
left a comment
There was a problem hiding this comment.
전반적으로 잘 작성하셨습니다. 고생 많으셨습니다!
- 현재 API 호출하는 부분이 공통 부분 쓰는 경우도 있고, 개별적으로 fetch를 쓰는 경우도 있습니다. 하나로 방식이 통일되고, API Base URL도 공통으로 분리해서 쓰면 재사용성에 도움이 될 것 같습니다.
Comment on lines
+40
to
+50
| if (err.message.includes("존재하지")) { | ||
| setModalMessage("존재하지 않는 이메일입니다."); | ||
| } else if (err.message.includes("비밀번호")) { | ||
| setModalMessage("비밀번호가 일치하지 않습니다."); | ||
| } else { | ||
| setModalMessage("로그인에 실패했습니다."); | ||
| } | ||
| setShowModal(true); | ||
| } finally { | ||
| setLoading(false); | ||
| } |
There was a problem hiding this comment.
보통 이런 경우에는 서버에서 내려준 값을 그대로 쓰거나, 아니면 에러 코드같은 걸 미리 만들어두고 매핑해서 보여주는 식으로 많이 사용합니다. 여기서는 이렇게 처리해준 특별한 이유가 있을까요?
There was a problem hiding this comment.
이 컴포넌트는 기능적으로 PasswordField 컴포넌트와 검증하는 부분 하나 제외하고는 동일한데 하나로 통합할 수 있을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게