[오하영] Sprint12 #244
Open
[오하영] Sprint12 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reach0908
approved these changes
Jul 9, 2025
reach0908
left a comment
reach0908
left a comment
There was a problem hiding this comment.
코드 가독성이나 타입안정성 측면에서 훨씬 좋아진 것 같습니다!
질문들에 대해서 고민해보고 다른 다양한 방법들이 있는지 고민해보시면 좋을 것 같아요!
| data.passwordConfirmation | ||
| ); | ||
| setIsSignupSuccess(result.success); | ||
| setIsSignupSuccess(result.success!); |
There was a problem hiding this comment.
[질문]
success가 result에서 없는 경우가 있나요?
백엔드에서 success를 항상 내려주면 signup 로직에서 리턴 타입을 명시해주면 될 것 같습니다.
그리고 비동기 로직의 경우 try catch로 에러핸들링을 하면 좋을 것 같습니다.
Comment on lines
+88
to
+96
| {articles && | ||
| articles.list.map((article) => { | ||
| return ( | ||
| <Link key={article.id} href={`/board/${article.id}`}> | ||
| <ArticleCard key={article.id} article={article} /> | ||
| <span className="my-6 flex border-b-1 border-gray-200"></span> | ||
| </Link> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
[P0]
이러면 아티클들이 없는 경우에는 빈공간이 나올 것 같은데, 기본 엠프티 컴포넌트나 처리가 있으면 좋을 것 같습니다
Comment on lines
+33
to
+34
| queryKey: ["products", { page: 1, pageSize, orderBy: "like" }], | ||
| queryFn: () => productService.getProducts({ page: 1, pageSize, orderBy: "like" }), |
There was a problem hiding this comment.
[P2]
키 팩토리 같은 것으로 키를 전역적으로 관리하는 방법도 있습니다!
| type="button" | ||
| className="btn-base bg-error-red h-12 w-22" | ||
| onClick={() => handleDelete(itemId)} | ||
| onClick={() => handleDelete?.(itemId!)} |
There was a problem hiding this comment.
[질문]
그럼 HandleDelete 함수가 빈 함수로 오는 경우에 해당 버튼은 동작하지 않는 버튼이 되나요?
|
사이트 다크모드에서 텍스트들의 컬러가 테마 설정과 맞지않아서 안보이는 이슈가 있는 것 같습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
공통
프론트엔드 배포
주요 변경사항
스크린샷
멘토에게