Fix #4552 an NPE in menu bar

[shai-almog]

No description provided.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2302 total, 0 failed, 0 skipped
• 📊 Line coverage: 53.00% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.util.EasyThread$InQueueRunnable – 0.00%
    • com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
    • com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
    • com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
    • com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
    • com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
    • com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
    • com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 94 more
  • ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1067 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1268 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 409 more
  • ❌ codenameone-maven-plugin: 480 findings (High: 1, Normal: 316, Low: 163)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 477 more
  • ✅ core-unittests: 0 findings (no issues)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1223 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:214 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 31 screenshots: 31 matched.

Native Android coverage

• 📊 Line coverage: 7.22% (3667/50800 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.62% (17985/319759), branch 2.72% (846/31105), complexity 3.36% (998/29727), method 5.92% (819/13843), class 9.68% (177/1828)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 7.22% (3667/50800 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.62% (17985/319759), branch 2.72% (846/31105), complexity 3.36% (998/29727), method 5.92% (819/13843), class 9.68% (177/1828)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

[shai-almog]

Compared 31 screenshots: 31 matched.
✅ Native Android screenshot tests passed.

Benchmark Results

• VM Translation Time: 314 seconds
• Compilation Time: 332 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	25801 ms
Extract Extensions	16 ms
Google Services Setup	2 ms
Scan Classes	493 ms
Extract Libs	926 ms
Inject Build Hints	44 ms
Generate Unit Tests	3 ms
Generate Stubs	962 ms
Compile Stubs	2149 ms
Generate Icons	1044 ms
Prepare ParparVM	183 ms
ParparVM Execution	181062 ms
Post-VM Setup	160 ms
CocoaPods	5637 ms
Finalize	33 ms
Total Time	218515 msMaven Overhead : 96000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot	90000 ms
Simulator Boot (Run)	3000 ms
App Install	15000 ms
App Launch	10000 ms
Test Execution	166000 ms