Run common tests from build script and tighten localization packaging/resource handling#4583
Closed
shai-almog wants to merge 6 commits intomasterfrom
Closed
Run common tests from build script and tighten localization packaging/resource handling#4583shai-almog wants to merge 6 commits intomasterfrom
shai-almog wants to merge 6 commits intomasterfrom
Conversation
Cloudflare Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ProjectOptions.PreviewLanguage.Description
INITIALIZR_RUN_TESTSsupport andRUN_TESTS_DEFAULTtoscripts/initializr/build.sh, with helper functionsshould_run_testsandrun_common_teststo optionally run thecommonmodule tests before platform-specific packaging steps.GeneratorModelMatrixTestandGeneratorModelLocalizationPackagingTestvia-Dtest=...to validate localization packaging behavior.GeneratorModel, introducedreadRequiredResourceToStringandaddLocalizationEntryand switched localization file insertion to use these helpers so missing required resources now raise an IOException rather than silently returning null.GeneratorModelMatrixTestto assert localization bundles via iteration overProjectOptions.PreviewLanguageinstead of hardcoding languages, and added a newGeneratorModelLocalizationPackagingTestthat compiles a dummy class and verifies generated localization resources load via a classloader.Testing
commonmodule tests with Maven using./mvnw -pl common -am test -DskipTests=false -DfailIfNoTests=false -Dtest=GeneratorModelMatrixTest,GeneratorModelLocalizationPackagingTestand both tests completed successfully.URLClassLoader, and it passed in the automated run.Codex Task