🤖 fix: add cross-platform path handling for Windows compatibility #540
+976
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/windows-build-fix
branch
3 times, most recently
from
8c7db4a to
d540ea3
Compare
ibetitsmike
force-pushed
the
mike/windows-build-fix
branch
from
d540ea3 to
2acdfbf
Compare
- Revert SSHRuntime/LocalRuntime/process cleanup edits - Remove platform-specific path layer and UI formatting - Restore bashExecutionService, execAsync, tests to main - Keep Windows build: Makefile bash shell + release.yml Windows job + setup-cmux action Only 3 files changed vs main: Makefile, release.yml, setup-cmux action.yml _Generated with `cmux`_.
…#572) This PR improves Windows build compatibility by introducing a conditional `RUNNER` variable in the Makefile. - **Add RUNNER variable** that conditionally uses: - `npx` on Windows (where `bun x` doesn't correctly pass arguments) - `bun x` on non-Windows systems for better performance - **Update all 30+ commands** to use `$(RUNNER)` instead of hardcoded `bun x` or `npx` - **Add explanatory comments** for Windows-specific behavior On Windows, `bun x` doesn't correctly pass arguments to commands, causing build failures. This change ensures consistent build behavior across all platforms by using the appropriate tool for each OS. ```makefile ifeq ($(OS),Windows_NT) RUNNER := npx else RUNNER := bun x endif ``` All commands now use `$(RUNNER)` for cross-platform compatibility. _Generated with `cmux`_
ibetitsmike
force-pushed
the
mike/windows-build-fix
branch
from
95b7df0 to
b09c032
Compare
- Add PlatformPaths class to handle Windows and Unix paths correctly - Replace all direct path operations with PlatformPaths methods - Support Windows drive letters, UNC paths, and backslash separators - Maintain consistent path abbreviation across platforms - Add comprehensive tests for all path operations
ibetitsmike
changed the title
- Remove unused path imports - Add eslint-disable comments for process usage in paths.ts (main-only functions) - Ensure compatibility with both main and renderer contexts
deansheather
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds comprehensive cross-platform path handling to support Windows builds alongside Unix systems.
Changes
New PlatformPaths utility class - Single source of truth for all path operations
Replaced all direct path operations throughout the codebase:
path.basename()→PlatformPaths.basename()expandTilde()→PlatformPaths.expandHome()abbreviatePath()→PlatformPaths.abbreviate()PlatformPaths.parse()Comprehensive test coverage - Tests verify correct behavior on both platforms
Testing
Generated with
mux